Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] decode href value before assertions #39947

Merged
merged 2 commits into from
Apr 5, 2022
Merged

[tests-only] decode href value before assertions #39947

merged 2 commits into from
Apr 5, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Description

  • decode href value before making assertions
  • do not assert href using regex pattern

Related Issue

Motivation and Context

cs3org/reva#2658 (comment)

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review April 4, 2022 12:08
@kiranparajuli589 kiranparajuli589 self-assigned this Apr 4, 2022
C0rby
C0rby approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@kiranparajuli589
Copy link
Contributor Author

still need to make changes for spaces webdav.

individual-it
individual-it requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not work for spaces, see
cs3org/reva#2658 (comment)

(just to make sure this is not accidentally merged)

@kiranparajuli589
Fix href case for spaces webdav
589c426 
Signed-off-by: Kiran Parajuli <[email protected]>
@individual-it individual-it merged commit cb55861 into master Apr 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the assert-entry-href-after-decode branch April 5, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@C0rby C0rby Awaiting requested review from C0rby

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranparajuli589 @phil-davis @individual-it @C0rby